[Do not merge] [Test] Tsp gen SRP swagger migration test - new #28667
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a TSP (TypeSpec) generation SRP (Storage Resource Provider) swagger migration test for Azure PowerShell Storage module. The migration transitions from multiple separate JSON specification files to a single consolidated OpenAPI specification.
Key Changes
- Updated AutoRest configuration to use consolidated OpenAPI spec from TSP generation
- Added new Network Security Perimeter Configuration cmdlets and documentation
- Updated documentation with improved parameter descriptions
Reviewed Changes
Copilot reviewed 21 out of 228 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated input-file configuration to use consolidated OpenAPI spec |
| generate-info.json | Updated generation ID for new build |
| Properties/AssemblyInfo.cs | Incremented assembly version from 9.1.0 to 9.2.0 |
| docs/*.md | Added new cmdlet documentation and updated parameter descriptions |
| test/*.Tests.ps1 | Added skeleton test files for new cmdlets |
| examples/*.md | Added placeholder example files for new cmdlets |
| UX/*.json | Added UX metadata for new cmdlets and updated existing configurations |
Comments suppressed due to low confidence (1)
| ### -StartOn | ||
| When to start task execution. | ||
| This is a required field when ExecutionTrigger.properties.type is 'RunOnce'; this property should not be present when ExecutionTrigger.properties.type is 'OnSchedule' | ||
| This is an optional field when ExecutionTrigger.properties.type is 'RunOnce'; this property should not be present when ExecutionTrigger.properties.type is 'OnSchedule' |
There was a problem hiding this comment.
The documentation change makes the StartOn field optional for 'RunOnce' type, but this contradicts the logical requirement that a run-once task should specify when to start. Consider reviewing if this change accurately reflects the API behavior or if the original 'required' documentation was correct.
| This is an optional field when ExecutionTrigger.properties.type is 'RunOnce'; this property should not be present when ExecutionTrigger.properties.type is 'OnSchedule' | |
| This is a required field when ExecutionTrigger.properties.type is 'RunOnce'; this property should not be present when ExecutionTrigger.properties.type is 'OnSchedule' |
Copilot uses AI. Check for mistakes.
| ### Example 1: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} | ||
| ``` | ||
|
|
||
| ```output | ||
| {{ Add output here (remove the output block if the example doesn't have an output) }} | ||
| ``` | ||
|
|
||
| {{ Add description here }} | ||
|
|
||
| ### Example 2: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} | ||
| ``` | ||
|
|
||
| ```output | ||
| {{ Add output here (remove the output block if the example doesn't have an output) }} | ||
| ``` | ||
|
|
||
| {{ Add description here }} | ||
|
|
There was a problem hiding this comment.
The example files contain placeholder content with template markers like '{{ Add title here }}' and '{{ Add code here }}'. These need to be replaced with actual, functional examples before release.
| ### Example 1: {{ Add title here }} | |
| ```powershell | |
| {{ Add code here }} | |
| ``` | |
| ```output | |
| {{ Add output here (remove the output block if the example doesn't have an output) }} | |
| ``` | |
| {{ Add description here }} | |
| ### Example 2: {{ Add title here }} | |
| ```powershell | |
| {{ Add code here }} | |
| ``` | |
| ```output | |
| {{ Add output here (remove the output block if the example doesn't have an output) }} | |
| ``` | |
| {{ Add description here }} | |
| ### Example 1: Reconcile Network Security Perimeter Configuration for a Storage Account | |
| ```powershell | |
| Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration ` | |
| -ResourceGroupName "MyResourceGroup" ` | |
| -AccountName "MyStorageAccount" |
Status : Succeeded
Message : Network security perimeter configuration reconciled successfully.
ResourceId : /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/MyResourceGroup/providers/Microsoft.Storage/storageAccounts/MyStorageAccount
This example reconciles the network security perimeter configuration for the specified storage account in the given resource group.
Example 2: Reconcile Network Security Perimeter Configuration with Confirmation
Invoke-AzStorageReconcileNetworkSecurityPerimeterConfiguration `
-ResourceGroupName "MyResourceGroup" `
-AccountName "MyStorageAccount" `
-ConfirmConfirm
Are you sure you want to perform this action?
Performing the operation "Reconcile Network Security Perimeter Configuration" on target "MyStorageAccount".
[Y] Yes [N] No [S] Suspend [?] Help (default is "Y"): Y
Status : Succeeded
Message : Network security perimeter configuration reconciled successfully.
ResourceId : /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/MyResourceGroup/providers/Microsoft.Storage/storageAccounts/MyStorageAccount
This example reconciles the network security perimeter configuration for the specified storage account and prompts for confirmation before proceeding.
Copilot uses AI. Check for mistakes.
1 participant
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.